Skip to content

fix: give admin roles to admin #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brettkolodny
Copy link
Collaborator

Copy link

vercel bot commented Jul 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2025 7:51pm

@brettkolodny brettkolodny self-assigned this Jul 9, 2025
@Parkreiner Parkreiner changed the title fix: give admin admin roles fix: give admin roles to admin Jul 9, 2025
Comment on lines +34 to +44
rbac_roles: [
...baseMockUser.rbac_roles,
{
name: "owner",
org_id: "",
},
{
name: "organization-admin",
org_id: "09942665-ba1b-4661-be9f-36bf9f738c83",
},
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know enough of our RBAC system to know what this code is doing for certain. Do you know of any documentation pages that'd be relevant here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super knowledgeable on the roles either, but it's the role I was told to add in the linked issue. I found the roles here in coder/coder.

Some more docs around the different roles here

Copy link
Member

@Parkreiner Parkreiner Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also tried going through the files in the repo, and didn't see anything that actually processes these roles. Are these properties being added for completion's/accuracy's sake, or is this change actually changing behavior?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching between these users can change how the forms render (assuming that you have logic within the terraform that depends on the different roles, groups, etc.).

There is no change in behavior directly, but the idea is that an admin user would have these roles so it makes more sense for examples. A PR I'm currently working on is to also add custom users which makes this less important but still better to have more common sense default values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playground: Give Admin user example the administrator role
2 participants